Skip to content

[ADHOC] update default validator signer in sdk#527

Merged
jonathandiep merged 3 commits intomainfrom
jon/update-signer
Mar 27, 2026
Merged

[ADHOC] update default validator signer in sdk#527
jonathandiep merged 3 commits intomainfrom
jon/update-signer

Conversation

@jonathandiep
Copy link
Copy Markdown
Contributor

@jonathandiep jonathandiep commented Mar 27, 2026 •
edited by coderabbitai bot
Loading

Description

update default validator signer in sdk

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced error handling in setup processes to properly distinguish between critical errors and non-critical warnings, preventing unnecessary failures and ensuring more reliable initialization.

  • Chores

    • Updated default testnet configuration parameters in the sample environment file.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

🦋 Changeset detected

Latest commit: e08d59f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@boostxyz/test" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 737c859e-1808-4528-80a9-748190b03bfb

📥 Commits

Reviewing files that changed from the base of the PR and between 3774ffc and e08d59f.

⛔ Files ignored due to path filters (1)
  • .changeset/three-readers-deny.md is excluded by !**/*.md
📒 Files selected for processing (2)
  • packages/sdk/.env.sample
  • test/src/setup.hardhat.ts
📜 Recent review details
🔇 Additional comments (2)
test/src/setup.hardhat.ts (1)

31-36: LGTM - Improved error handling for Hardhat stderr.

The change to filter out npm warn messages prevents benign warnings from failing the Hardhat process setup, which is a sensible improvement.

Minor observation: reject(data) still passes the raw Buffer while msg is logged as a string. For consistency, consider using reject(new Error(msg)) to provide a more informative rejection.

packages/sdk/.env.sample (1)

5-6: Address format is valid and will be automatically registered as a signer.

The address 0x9fa7306a3edb74068900e6fdc7e10ebfb2c03fb4 is in the correct format (42 characters: 0x + 40 hex). It will be automatically registered as an authorized signer when the default validator is created, as shown in BoostCore.ts lines 906-922, where this address from VITE_BOOST_TESTNET_SIGNER_EOA is included in the signers array passed to LimitedSignerValidatorV2. The test expectation at BoostCore.test.ts:867-869 will pass as long as the validator deploys successfully.

			> Likely an incorrect or invalid review comment.
📝 Walkthrough

Walkthrough

This pull request makes two updates: changing a testnet signer address in the SDK environment configuration file and modifying Hardhat's child-process stderr handling to avoid rejecting on npm warnings.

Changes

Cohort / File(s) Summary
Environment Configuration
packages/sdk/.env.sample		 Updated the VITE_BOOST_TESTNET_SIGNER_EOA value to a new address.
Test Setup
test/src/setup.hardhat.ts		 Modified stderr handling in Hardhat process setup to only reject promises on errors that do not include npm warn messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A signer hops to a new address bright,
While Hardhat's stderr learns what's wrong from right—
No warnings to fret, just errors so true,
The rabbit approves these fixes so new! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is minimal and lacks substantive detail about the change, rationale, testing, or follow the template structure with recommended guidelines link. Expand the description to explain why the signer address was changed, any related testing performed, and include the repository guidelines reference from the template.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the default validator signer in the SDK, which is confirmed by the .env.sample file modification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jon/update-signer

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonathandiep
Copy link
Copy Markdown
Contributor Author

jonathandiep commented Mar 27, 2026

Warnings
⚠️

By using the [ADHOC] title prefix, you are bypassing best practice protections.

Generated by 🚫 dangerJS against e08d59f

1 similar comment
@jonathandiep
Copy link
Copy Markdown
Contributor Author

jonathandiep commented Mar 27, 2026

Warnings
⚠️

By using the [ADHOC] title prefix, you are bypassing best practice protections.

Generated by 🚫 dangerJS against e08d59f

@jonathandiep jonathandiep merged commit 0462aa7 into main Mar 27, 2026
7 checks passed
@jonathandiep jonathandiep deleted the jon/update-signer branch March 27, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

changeset SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonathandiep